Skip to content

Generic fallback for fillstored! #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2025
Merged

Generic fallback for fillstored! #1389

merged 3 commits into from
Sep 1, 2025

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 20, 2025 •
edited
Loading

Also, specialize for Adjoint/Transpose to dispatch to the methods for the parent.

The following works after this:

julia> U = Adjoint(UpperTriangular(zeros(2,2)))
2×2 adjoint(::UpperTriangular{Float64, Matrix{Float64}}) with eltype Float64:
 0.0   ⋅ 
 0.0  0.0

julia> LinearAlgebra.fillstored!(U, 3)
2×2 adjoint(::UpperTriangular{Float64, Matrix{Float64}}) with eltype Float64:
 3.0   ⋅ 
 3.0  3.0

@codecov Codecov
Copy link

codecov bot commented Jun 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.88%. Comparing base (76e280e) to head (04503d4).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1389      +/-   ##
==========================================
- Coverage   93.89%   93.88%   -0.01%     
==========================================
  Files          34       34              
  Lines       15896    15900       +4     
==========================================
+ Hits        14925    14928       +3     
- Misses        971      972       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub merged commit 1f55352 into master Sep 1, 2025
4 checks passed
@jishnub jishnub deleted the jishnub/filstored_adjtrans branch September 1, 2025 19:38
@ViralBShah
Copy link
Member

Ok to backport to 1.12?

@ViralBShah ViralBShah added the backport 1.12 Change should be backported to release-1.12 label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport 1.12 Change should be backported to release-1.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jishnub @ViralBShah